Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set opengraph attributes on org pages #12803

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Set opengraph attributes on org pages #12803

merged 2 commits into from
Sep 11, 2020

Conversation

zeripath
Copy link
Contributor

Fix #12778

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Set opengraph attributes on org pages
64f4d1a 
Fix go-gitea#12778

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Sep 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #12803 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12803      +/-   ##
==========================================
+ Coverage   43.15%   43.18%   +0.02%     
==========================================
  Files         651      651              
  Lines       72134    72136       +2     
==========================================
+ Hits        31132    31150      +18     
+ Misses      35948    35938      -10     
+ Partials     5054     5048       -6
Impacted Files Coverage Δ
routers/org/home.go 66.66% <100.00%> (+0.75%) ⬆️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
routers/repo/view.go 37.47% <0.00%> (-0.65%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
services/pull/pull.go 41.57% <0.00%> (ø)
models/gpg_key.go 55.40% <0.00%> (+0.58%) ⬆️
models/error.go 35.66% <0.00%> (+0.85%) ⬆️
models/notification.go 67.04% <0.00%> (+0.91%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd9ca3...c30669b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2020
6543
6543 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 11, 2020
@zeripath zeripath merged commit a064153 into go-gitea:master Sep 11, 2020
@zeripath zeripath deleted the fix-12778-set-PageIsUserProfile-on-org-page branch September 11, 2020 06:41
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Open Graph dont show Org Avatars
6 participants
@zeripath @codecov-commenter @mrsdizzie @6543 @GiteaBot @lunny